fktn-k / fkYAML

A C++ header-only YAML library
MIT License
67 stars 7 forks source link

Fix parse error on smal negative integer keys #355

Closed fktn-k closed 4 months ago

fktn-k commented 4 months ago

The current parser mistakenly emits parse errors on small negative integer keys like the following valid YAML snippet:

# This causes a false error which tells there is an invalid ending of a flow mapping.
{-4: bar}

This was caused by the wrong lookahead implemented for tokens which start with a hyphen(-).
So, this PR has fixed it and the above snipet is now parsed successfully.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

Please don't

github-actions[bot] commented 4 months ago

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 46e831e3404672788f3044e34f3c20c9a0125b14. You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr355.zip
ID 1560427092
URL https://github.com/fktn-k/fkYAML/actions/runs/9340029437/artifacts/1560427092
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9340029437

Details


Totals Coverage Status
Change from base Build 9339279478: 0.0%
Covered Lines: 3901
Relevant Lines: 3901

💛 - Coveralls