fktn-k / fkYAML

A C++ header-only YAML library
MIT License
67 stars 7 forks source link

Fix bug in serializing alias keys #364

Closed fktn-k closed 3 months ago

fktn-k commented 3 months ago

The current serializer changes alias names when they are used as a mapping key.
For example, serializing the following YAML snippet:

foo: &A bar
*A : baz

the serializer emits the following wrong result since alias names can contain colons:

foo: &A bar
*A: baz # alias name mistakenly becomes "*A:".

So, this PR has fixed the above issue and now the serializer emits correct alias keys.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

Please don't

github-actions[bot] commented 3 months ago

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit c7eab4f7359e771af0b150eb95fd993a628edc94. You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr364.zip
ID 1605474256
URL https://github.com/fktn-k/fkYAML/actions/runs/9532833656/artifacts/1605474256
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9532833656

Details


Totals Coverage Status
Change from base Build 9532729985: 0.0%
Covered Lines: 3929
Relevant Lines: 3929

💛 - Coveralls