#375 Fix newline code normalization in UTF-8 encoded file input

fktn-k commented 1 month ago

This PR has fixed the newline code normalization of CR+LF into LF contained in a given file for deserialization, which is the root cause of the bug reported in the issue #375.
Before the fix, CR+LF newline codes were normalized mistakenly into CR, which broke the subsequent deserialization process which intentionally ignores the existence of CR for optimization.
By correcting the normalization logic, CR+LF are now successfully normalized into LF.

Furthermore, since the normalized input value checks were somehow dropped in the input_adapter module test cases, the appropriate checks have also been added.

Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

[x] Changes are described in the pull request or in a referenced issue.
[x] The test suite compiles and runs without any error.
[x] The code coverage on your branch is 100%.
[x] The documentation is updated if you added/changed a feature.

Please don't

The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
Please do not open pull requests that address multiple issues.

github-actions[bot] commented 1 month ago

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 5fcb72cd05ad92a8722e5254980edfae2685ae27. You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name	fkYAML_coverage.pr376.zip
ID	1828296426
URL	https://github.com/fktn-k/fkYAML/actions/runs/10456730369/artifacts/1828296426

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 10456730369

Details

4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 10442147415:	0.0%
Covered Lines:	3971
Relevant Lines:	3971

fktn-k / fkYAML