fkuehne / upnpx

Officially endorsed fork of the discontinued upnpx library by Bruno Keymolen
Other
260 stars 113 forks source link

Memory leaks in BasicParser.m #64

Closed lightbow closed 8 years ago

lightbow commented 9 years ago

BasicParser.m uses the old memory manual memory management system for Objective-C instead of ARC, so it's easy to make changes and accidentally forget a "release" or two. Here are four instances uncovered by the static analyzer:

Line 98 calls elementStack = [stack copy] with no subsequent release Line 99 calls assets = [mAssets copy] with no subsequent release Lines 163 and 185 call NSString *xml = [[NSString alloc] initWithData:data encoding:NSUTF8StringEncoding]; with no subsequent release