search

flaccidware / webm

Automatically exported from code.google.com/p/webm
0 stars 0 forks source link

vp8_sub_pixel_variance8x8_neon fails variance unit tests #1017

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
v1.4.0-480-g8134d68

[  FAILED  ] NEON/VP8SubpelVarianceTest.ExtremeRef/0, where GetParam() = (3, 3, 
0x14e36d, 0)
[  FAILED  ] NEON/VP8SubpelVarianceTest.Ref/0, where GetParam() = (3, 3, 
0x14e36d, 0)

since: eb88b17 Make vp9 subpixel match vp8

these likely were broken since they were adapted from the assembly

Original issue reported on code.google.com by jz...@google.com on 6 Jun 2015 at 3:19

GoogleCodeExporter commented 9 years ago 
Argh I probably only tested the assembly version. Should have run 
--disable-neon-asm or armv8 target. Yeah, most likely broken the whole time and 
we aren't deployed on many 64bit targets.

Original comment by johann.k...@gmail.com on 6 Jun 2015 at 3:51

GoogleCodeExporter commented 9 years ago 
The function is disabled for now:

https://chromium-review.googlesource.com/#/c/275732

Original comment by jz...@google.com on 6 Jun 2015 at 4:06

GoogleCodeExporter commented 9 years ago

Original comment by fgalli...@google.com on 18 Jun 2015 at 10:07

GoogleCodeExporter commented 9 years ago 
Will be "fixed" be replacing the vp8 version with the vp9 version:
https://chromium-review.googlesource.com/#/c/281967/

Original comment by johannkoenig@google.com on 30 Jun 2015 at 12:58

GoogleCodeExporter commented 9 years ago 
neon vp8 sub pixel has been replaced by the vp9 version which does pass the 
tests.

Original comment by johannkoenig@google.com on 9 Jul 2015 at 7:45