search

flacjacket / pywlroots

Python binding to the wlroots library using cffi
University of Illinois/NCSA Open Source License
51 stars 12 forks source link

Enable xwayland feature for wlroots build step when making a release #113

Closed m-col closed 1 year ago

m-col commented 1 year ago

This is already set in the ci.yaml, but not in release.yaml. It needs to be set because its false by default in wlroots.

Closes #112

I think this should work, but I'm not certain. Is there a way to do test releases to pypi?

flacjacket commented 1 year ago

Thanks for this, I just created a tag v0.16.1.dev0, which should show up on the test pypi instance once the CI job runs. Let me know if this fixes the problem there.

flacjacket commented 1 year ago

Also, our tests here are currently very sparse, even just basic tests to see if this symbol is defined would be great to add!

flacjacket commented 1 year ago

https://test.pypi.org/project/pywlroots/0.16.1.dev0/

m-col commented 1 year ago

pip-installing pywlroots==v0.16.1.dev0 didn't resolve the issue.Jjust to check that I understood you correctly - that tag was made using this PR, or the PR's CI will push a new package on top of the tag to the test pypi instance?

flacjacket commented 1 year ago

I created a new branch based off your branch here: https://github.com/flacjacket/pywlroots/tree/mcol/enable_xwayland_release I did the version bump and added the tag on that branch. The test pypi package will only be created for tags, not for PRs (you could edit the .github/workflows/release.yml file to make the test pypi push run on PRs for testing purposes, but it might just be easier to add something to the Test wheels section that checks if that symbol is defined).

flacjacket commented 1 year ago

I think I was able to get this figured out, and was able to land this with the fix! Let me know if this doesn't do everything we need in the current released wheels in 0.16.1.