search

flacjacket / pywlroots

Python binding to the wlroots library using cffi
University of Illinois/NCSA Open Source License
51 stars 12 forks source link

Wlr 0.17 #167

Closed jwijenbergh closed 4 months ago

jwijenbergh commented 5 months ago

supersedes #129, testing CI here. totally not done yet, currently I just added the fractional scale API. Need to see what is missing here

jwijenbergh commented 5 months ago

@flacjacket if you have the time can you approve CI on this

heuer commented 5 months ago

This is great, thank you @jwijenbergh and @m-col!

I'd love to see pywlroots 0.17.0.

elParaguayo commented 4 months ago

Hi @flacjacket

A polite nudge on this. Would be great if we can move onto 0.17 support soon.

Thanks!

flacjacket commented 4 months ago

Thank you for this! I missed that this was a PR and not an issue noting what is needed to get to 0.17. I'll take a look at this this weekend, if it is possible to update the conflicts we can work on getting this merged in!

jwijenbergh commented 4 months ago

Thank you for this! I missed that this was a PR and not an issue noting what is needed to get to 0.17. I'll take a look at this this weekend, if it is possible to update the conflicts we can work on getting this merged in!

Thanks! Will work on the conflicts and CI later today

jwijenbergh commented 4 months ago

Okay it's green, time to fixup the commits and add some fixes

jwijenbergh commented 4 months ago

Marked ready for review.

jwijenbergh commented 4 months ago

need to cleanup inconsistencies between output state and normal output setters/getters

flacjacket commented 4 months ago

Thanks for pushing to make this happen!