search

flacjacket / pywlroots

Python binding to the wlroots library using cffi
University of Illinois/NCSA Open Source License
51 stars 12 forks source link

Check usage of context managers #168

Open heuer opened 4 months ago

heuer commented 4 months ago

It's a minor issue but several classes provide a context manager where it makes no sense, in my opinion. For example: Where is the use case for a context manager in Output, or CursorManager, or Cursor…?

In my opinion all context managers which have no valid use case should be removed.

heuer commented 4 months ago

OutputLayout is another candidate where the value of a context manager is questionable.

heuer commented 3 months ago

@flacjacket, @jwijenbergh, maybe WLR 0.17 offers a chance to clean this up?

However, I don't think this issue is important enough to delay a release of WLR 0.17.