Added support for OutputState

flacjacket / pywlroots

Python binding to the wlroots library using cffi

University of Illinois/NCSA Open Source License

51 stars 12 forks source link

Added support for OutputState #171

Closed heuer closed 4 months ago

heuer commented 5 months ago

Added OutputState to wlr_types/output.py
Moved CustomMode from wlr_types/output_management_v1.py to wlr_types/output.py
Added OutputHeadV1State.apply(OutputState) (closes #149)
Fixed OutputHeadV1State.custom_mode setter (closes #170)
Output.test() and Output.commit() accept an optional OutputState object

All changes should be backwards compatible.

heuer commented 5 months ago

Note to @jwijenbergh and @m-col: I wanted to use the OutputState from the WLR-17 branch, but it missed some functionality, so I came up with my own implementation.

Further differences from the WLR-17 branch: The Output.commit() and .test() methods take an optional OutputState object so the Output.commit_state() and Output.test_state() methods are superfluous.

jwijenbergh commented 5 months ago

Nice! You may also send a PR into my wlr 0.17 if you want

heuer commented 5 months ago

You may also send a PR into my wlr 0.17

How can I do that? Github doesn't allow a fork of your repository because I already have a fork of the main repository

jwijenbergh commented 5 months ago

You may also send a PR into my wlr 0.17

How can I do that? Github doesn't allow a fork of your repository because I already have a fork of the main repository

Add me as a remote, rebase pr on top of the wlr 0.17 branch and then click new pull request in my fork