flackbash / AudioAnchor

Android audio player that tracks the listening progress of your audio books and podcasts
GNU General Public License v3.0
221 stars 42 forks source link

AUDIO DOES NOT PAUSE WHEN RECEIVING SOUND NOTIFICATION #114

Closed G-i-o closed 3 years ago

G-i-o commented 3 years ago

Hello.

Thank You for providing this little gem.

Just wanted to report....when I make or receive a call, while listening with AudioAnchor, the audio is placed on pause and restarted when the call has ended. However, this does not work with sound notifications. So, for instance, when I go for long walks, I like to listen to podcasts and have a tracking app for my walk too. The tracking app sends me a voice notification every ten min to inform me on my progress and the notification lasts about 10-15 secs. During this time AudioAnchor lowers the volume for itself but does not pause. Hence, I lose those 10-15 seconds of the podcast.

This is in reference to the current latest version, 2.2.3, on Android 10 (Lineage equivalent).

flackbash commented 3 years ago

There is an option in the settings called "Duck audio when playback is interrupted" which was added in #101 thanks to @awaters1 . It is right now enabled by default (maybe I should change that). If you disable it I think you have what you're looking for. I'll close the issue, but if this does not fix your problem, feel free to reopen it.

G-i-o commented 3 years ago

I tried that with it on and off. Unfortunately, in both cases the outcome is identical: when the announcement come through, AudioAnchor lowers the volume of the audio that is being played but it does not stop it.

🙏️

On Sat, 2021-05-15 at 05:32 -0700, Natalie Prange wrote:

There is an option in the settings called "Duck audio when playback is interrupted" which was added in #101 thanks to @awaters1 . It is right now enabled by default (maybe I should change that). If you disable it I think you have what you're looking for. I'll close the issue, but if this does not fix your problem, feel free to reopen it. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

awaters1 commented 3 years ago

Can you share the name of the tracking app? I only tested the audio ducking feature that I added with Google Maps. It is possible the other app isn't setting the right audio settings or just a bug in code I wrote, not quite sure yet.

G-i-o commented 3 years ago

Sure. It's OpenTracks (https://github.com/OpenTracksApp/OpenTracks ).

Beware, though, that Voice (https://github.com/PaulWoitaschek/Voice ), an app most similar to yours, has not this issue. When I listen to Voice and then receive not just audio notifications (any), calls etc. from any app but any sound (even alarms from timers etc.), Voice does stop and then restart the audio when the sound have finished.

Hope it helps. 🙏️

On Sat, 2021-05-15 at 06:05 -0700, Anthony Waters wrote:

Can you share the name of the tracking app? I only tested the audio ducking feature that I added with Google Maps. It is possible the other app isn't setting the right audio settings. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

awaters1 commented 3 years ago

Thank you for the bug report, I did some testing and on my device with Android 7 it works, however, I tried an Android 9 device, and the audio didn't stop properly (so doesn't work). I'll have to take a look into it a little more to figure out a fix.

G-i-o commented 3 years ago

Thank You for looking into this and so promptly. Much appreciated. 🙏️

On Sat, 2021-05-15 at 14:06 -0700, Anthony Waters wrote:

Thank you for the bug report, I did some testing and on my device with Android 7 it works, however, I tried an Android 9 device, and the audio didn't stop properly (so doesn't work). I'll have to take a look into it a little more to figure out a fix. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

flackbash commented 3 years ago

Merged. This will be in the next release. Thanks for reporting @G-i-o and thanks for the fix @awaters1 !

G-i-o commented 3 years ago

Thank You Natalie & Awaters for promptly acting on this. You've been great.

If there's a cryptocurrency address (Preferably not BTC for environmental reasons) where I can send a donation to support the project, I'll be happy to do so.

Again, much appreciation. 🙏️

On Mon, 2021-05-17 at 11:22 -0700, Natalie Prange wrote:

Merged. This will be in the next release. Thanks for reporting @G-i-o and thanks for the fix @awaters1 ! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

flackbash commented 3 years ago

Unfortunately, there is no cryptocurrency address to support the development of AudioAnchor, yet. But thank you anyway, the thought counts :)

I added a PayPal donation link in the About section of the app now, since I've had requests about donations before (in case PayPal is an alternative for you).

I just published a new release which also includes @awaters1 fix for this issue, so it should be on F-Droid within the next few days :)

G-i-o commented 3 years ago

Thank You very much for this. Just started to use the updated version from F-Drod and it now works beautifully. :pray: