flackr / scroll-timeline

A polyfill of ScrollTimeline.
Apache License 2.0
951 stars 94 forks source link

Support CSSNumericValues as inset #177

Closed johannesodland closed 9 months ago

johannesodland commented 10 months ago

Depends on https://github.com/flackr/scroll-timeline/pull/176

This PR adds support for passing CSSNumericValues as insets to ViewTimeline.

new ViewTimeline({
  subject: elm,
  axis: 'block',
  inset: [ CSS.percent(10), CSS.percent(20) ]
})

To pass the tests the PR also do the following:

This PR does not:

flackr commented 9 months ago

Uhoh, looks like my naive diff of test results approach has encountered it's first issue with what seems to be a flaky test.