search

flackr / scroll-timeline

A polyfill of ScrollTimeline.
Apache License 2.0
890 stars 84 forks source link

Proxied Animations Cleanup fixup #184

Closed bramus closed 6 months ago

bramus commented 6 months ago

In #89 the proxied animations handling got moved around a bit. In #147 (which was merged earlier) a cleanup mechanism for the old proxyAnimations was introduced, but this mechanism was not removed in #89. This went unnoticed as it only triggers an error when running in strict mode, as reported in #183.

This PR fixes that.

flackr commented 6 months ago

Thanks for the fix! I'll look into ensuring that the proxy is tested in strict mode so that this would have been caught by the tests.