search

flackr / scroll-timeline

A polyfill of ScrollTimeline.
Apache License 2.0
890 stars 84 forks source link

Remove test summary from test output. #211

Closed flackr closed 5 months ago

flackr commented 5 months ago

Having the summary line leads to every PR which alters test expectations conflicting with every other PR which alters them. The summary can be computed by grepping the PASS / FAIL lines anyways so this should reduce the number of merge conflicts to only cases where the same sets of test expectations changed.

flackr commented 5 months ago

@johannesodland I'm hoping this helps reduce the churn with multiple PRs

johannesodland commented 5 months ago

Maybe we could add the summary line to the workflow summary?

      - name: Adding summary
        run: echo "Passed $(grep -c '^PASS' ./test/report/summary.txt) of $(grep -c '^'  ./test/report/summary.txt) tests" >> $GITHUB_STEP_SUMMARY
flackr commented 5 months ago

Maybe we could add the summary line to the workflow summary?

      - name: Adding summary
        run: echo "Passed $(grep -c '^PASS' ./test/report/summary.txt) of $(grep -c '^'  ./test/report/summary.txt) tests" >> $GITHUB_STEP_SUMMARY

Great suggestion, I've added this step as suggested.