search

flackr / scroll-timeline

A polyfill of ScrollTimeline.
Apache License 2.0
891 stars 84 forks source link

Return "normal" for get rangeStart and rangeEnd #223

Closed johannesodland closed 5 months ago

johannesodland commented 5 months ago

We should return the string "normal" for rangeStart and rangeEnd (when specified as normal), and not a TimelineRangeOffset.

This change makes view-timeline-get-set-range.html pass again, given that it is run on an uncompressed build (https://github.com/flackr/scroll-timeline/pull/200) and that we have a proper implementation of CSSNumericValue.parse() (https://github.com/flackr/scroll-timeline/pull/206).

johannesodland commented 5 months ago

@bramus Thanks for letting me know 🙏

I've rebased the branch, and the tests are now passing :)