flafflar / panon

An Audio Visualizer Widget in KDE Plasma (works in KDE Plasma 6)
GNU General Public License v3.0
21 stars 2 forks source link

[BUG] {Some Downloadable visual effects don't work} #8

Open Lancaban opened 2 months ago

Lancaban commented 2 months ago

Alright, I'm not sure if there is anything that can be done about this, from this end but here it goes.

A few of the downloadable visual effects no longer work with this Plasma6 updated version.

They worked with plasma 5, as recently as several months ago, even though the github release for the effects themselves hasn't been updated in over 3 years.

So I'm assuming there is something in the fix for plasma 6 that is causing the visualization to break, I fully understand there may be nothing that can be done about it.

Specifically - https://github.com/rbn42/panon-effects

As said It may be something in that plugin that needs to be fixed, and is therefore beyond the scope of this github repo, but Something that hasn't been touched in 3 years, seems like not the best place to start for reporting what is essentially a "recent" bug.

flafflar commented 2 months ago

Basically, Qt changed how shaders can be loaded, so the shader system had to be rebuilt. This made shaders written for the old version incompatible. An update of the old shaders in https://github.com/rbn42/panon-effects is on the way though. If you use any other effect that is not in the panon-effects repo, you can submit it here so it can be included in the update.

Lancaban commented 2 months ago

Alright, thanks so much for the info. I really appreciate it.

hero-hz1999yt commented 1 month ago

Incredible work brother !!!! @flafflar