MSVC link error in minidump.obj ParseProcMaps

[GoogleCodeExporter]

Steps to reproduce
1. Checkout r1498 on Windows
2. Build with MSVC2013
3. See the link error

Details for 2.
----------------

How I build:

call "C:\Program Files (x86)\Microsoft Visual Studio 
12.0\Common7\Tools\VsDevCmd.bat"
C:\python27\python src\tools\gyp\gyp_main.py --no-circular-check 
src\client\windows\breakpad_client.gyp
msbuild src\client\windows\build_all.vcxproj /p:Configuration=Debug;Platform=x86
msbuild src\client\windows\build_all.vcxproj 
/p:Configuration=Release;Platform=x86

Details for 3.
----------------

processor_bits.lib(minidump.obj) : error LNK2019: unresolved external symbol 
"bool __cdecl google_breakpad::ParseProcMaps(class 
std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> 
> const &,class std::vector<struct google_breakpad::MappedMemoryRegion,class 
std::allocator<struct google_breakpad::MappedMemoryRegion> > *)" 
(?ParseProcMaps@google_breakpad@@YA_NABV?$basic_string@DU?$char_traits@D@std@@V?
$allocator@D@2@@std@@PAV?$vector@UMappedMemoryRegion@google_breakpad@@V?$allocat
or@UMappedMemoryRegion@google_breakpad@@@std@@@3@@Z) referenced in function 
"private: virtual bool __thiscall 
google_breakpad::MinidumpLinuxMapsList::Read(unsigned int)" 
(?Read@MinidumpLinuxMapsList@google_breakpad@@EAE_NI@Z) [C:\Program Files 
(x86)\Go 
Agent\pipelines\google-breakpad\google-breakpad\src\client\windows\unittests\cli
ent_tests.vcxproj]

and

processor_bits.lib(minidump.obj) : error LNK2019: unresolved external symbol 
"bool __cdecl google_breakpad::ParseProcMaps(class 
std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> 
> const &,class std::vector<struct google_breakpad::MappedMemoryRegion,class 
std::allocator<struct google_breakpad::MappedMemoryRegion> > *)" 
(?ParseProcMaps@google_breakpad@@YA_NABV?$basic_string@DU?$char_traits@D@std@@V?
$allocator@D@2@@std@@PAV?$vector@UMappedMemoryRegion@google_breakpad@@V?$allocat
or@UMappedMemoryRegion@google_breakpad@@@std@@@3@@Z) referenced in function 
"private: virtual bool __thiscall 
google_breakpad::MinidumpLinuxMapsList::Read(unsigned int)" 
(?Read@MinidumpLinuxMapsList@google_breakpad@@EAE_NI@Z) [C:\Program Files 
(x86)\Go 
Agent\pipelines\google-breakpad\google-breakpad\src\client\windows\unittests\cli
ent_tests.vcxproj]

Original issue reported on code.google.com by war...@gmail.com on 17 Sep 2015 at 1:47

Attachments:

• r1498-msvc.txt

[GoogleCodeExporter]

I think we just need to update the client_tests.gyp file to include new source 
files that were added. (Sure wish we weren't maintaining multiple build 
systems!)

Original comment by tmielcza...@mozilla.com on 17 Sep 2015 at 3:06

[GoogleCodeExporter]

The same happens for both debug and release. Issue occurs in latest 1be03d4 in 
the git repository as well.

Original comment by war...@gmail.com on 17 Sep 2015 at 3:07

[GoogleCodeExporter]

Is there another recommended build system I can use on Windows and Linux?

Original comment by war...@gmail.com on 17 Sep 2015 at 3:09

[GoogleCodeExporter]

On Linux you can use the autotools build--`./configure && make`. On Windows we 
don't have an alternative. I'll see if I can fix this.

Original comment by ted.mielczarek on 17 Sep 2015 at 3:34

[GoogleCodeExporter]

https://codereview.chromium.org/1353893002

Original comment by ted.mielczarek on 17 Sep 2015 at 4:16

[GoogleCodeExporter]

Thanks a lot, patch works for me

Original comment by war...@gmail.com on 17 Sep 2015 at 5:09

[GoogleCodeExporter]

Fixed in:
https://chromium.googlesource.com/breakpad/breakpad/+/be849f06377071576eae5aaaf4
9e033b7a747ea7

Original comment by ted.mielczarek on 6 Oct 2015 at 12:06

• Changed state: Fixed