flaghunters / Extra-Flags-for-4chan

Extra Flags for 4chan boards, supports /int/, /sp/ and /pol/.
https://flaghunters.github.io/Extra-Flags-for-4chan/
Other
46 stars 65 forks source link

Migrate flags to region folders (cascading) #222

Closed WhatIsThisImNotGoodWithComputers closed 8 years ago

WhatIsThisImNotGoodWithComputers commented 8 years ago

We have two folders now, we will be moving from "flegs" to "flags".

In flags we see a new structure. The top level folders are countries, quite the same as flegs. What we need are cascading regions.

For example:

See flags folder for how the structure should be.

Delftanon commented 8 years ago

Canada.zip

Here's Canada done. New Brunswick and Prince Edward Island do not have any flags as of yet, added the folders anyway. Iroquois is "a historically powerful and important northeast Native American confederacy" so I don't think it belongs in any province folder.

karakalpak commented 8 years ago

What if some provinces have flags but some don't? I created the flags for Turkey, and every province has city flags but half of the provinces themselves don't have their own flags.

Anonymous7432 commented 8 years ago

I have a question about this

Will the cascading flags/extra regional flags (not sure of the correct term) be optional?

I appreciate the concept, but im not sure that every user will want to post with a list of potentially 4 flags all the time (eg. UK-England/Scotland/etc-County-City/Locality)

Please dont take this as me bashing the idea; I see why a lot of posters might want it, especially the flag collectors

All im saying is that it should be an optional feature. Maybe thats already the intention. Just wanted to voice my concerns.

WhatIsThisImNotGoodWithComputers commented 8 years ago

@karakalpak Best would be to add coa's or something comparable, if that's not possible, I'd say just put them in, not in folders, just as the top regions for Turkey.

@Anonymous7432 for posting the user decides how many flags they send but they must start at the highest division. For showing flags there will be a self-filter to limit the flags to only 1, might have to make an exception for UK. Filter is yet to be implemented.

ghost commented 8 years ago

Flags 1.zip This includes -Austria -Former Yugoslavia -Italy -Spain

ghost commented 8 years ago

Austria.zip Fugg

karakalpak commented 8 years ago

Alri I'll do Turkey later today.

Edit: I'll need a while

WhatIsThisImNotGoodWithComputers commented 8 years ago

Thanks, they're added

WhatIsThisImNotGoodWithComputers commented 8 years ago

So we're still missing a few, anyone know which ones?

karakalpak commented 8 years ago

All of Oceania, Africa and Asia save for Turkey, SK, Japan, the Philippines, India and Sri Lanka are done. I have Belarus ready (with new city flags) and I'll submit it tonight with remade Brazil and some of the rest of Latin America.

Europe still has a long way to go. (Also Delft anon has done Canada ITT but you haven't added it)

WhatIsThisImNotGoodWithComputers commented 8 years ago

Oh shit, don't know how I could've missed that, added Canada now. As lot of Europe is missing we'll have to wait for a bit longer.

Malte-Soeren commented 8 years ago

Just did all of germany, I added flags for the administrative divisions between Bundesländer and Landkreise, the Bezirke (for the four Bundesländer that have those), some didn't have any flag or coat of arms, so they got just a white, glossed 16x11px flag: http://www.mediafire.com/download/uty42ngysi2385b/regionflags_germany.zip

Edit: and of course all Spelling Errors of german flags that i've pointed out in #228 have been fixed here

ghost commented 8 years ago

Apparently I forgot to add Macedonia Macedonia.zip

ghost commented 8 years ago

Switzerland.zip

sdjklag commented 8 years ago

Do I need to add the new flags to both flags/ and flegs/?

WhatIsThisImNotGoodWithComputers commented 8 years ago

Should be flags, flegs is optional now and will be deleted once we switch to v2.

WhatIsThisImNotGoodWithComputers commented 8 years ago

Added Macedonia and Switzerland from this thread.

WhatIsThisImNotGoodWithComputers commented 8 years ago

Also added Germany.

Please open new tickets for countries you submit instead of a comment, they're too easy to miss if they're not a separate issue.

WhatIsThisImNotGoodWithComputers commented 8 years ago

Just moved Hong Kong from flegs to flags, this seemed to be the last one. The only ones missing are Yemen and Unknown, but they are both meme flags.

Can anyone confirm whether we're done or not, because I think we're ready.

flagzzzz commented 8 years ago

Looks good here. One anon is sorting and renaming some flags right now but after that, I think we'll be ready

flagzzzz commented 8 years ago

Last update has been made, I think we're ready now

WhatIsThisImNotGoodWithComputers commented 8 years ago

Alright. I'll finalize tomorrow morning.