flagrow / ads

Allows you to configure ads in several locations
https://discuss.flarum.org/d/4785-flagrow-ads-bombarding-your-users-with-ads-everywhere-if-you-want
MIT License
18 stars 9 forks source link

Add ads under reply box. #15

Closed noriods closed 6 years ago

noriods commented 6 years ago

This PR adds a field in the admin where you can put ad-code for ads you'd like to show under the reply box. Please let me know if there's anything that can be improved to get this PR accepted.

noriods commented 6 years ago

I was missing the setting in the listener that grabs the settings from the DB. It's now working properly on my website. (I just assumed it was a cache thing! 🙄)

noriods commented 6 years ago

@luceos I'm noticing some conflicts between this and the way Flarum handles replying. I need to move the ad-spot. Please don't merge just yet. (I'm actively testing it on my production forum.)

luceos commented 6 years ago

I totally missed this one 😊

I'm going over all extensions after beta 8 has been released. With this one somewhere at the top of the list.

luceos commented 6 years ago

Feel free to create a new one if you're interested 👍