search

flagrow / ads

Allows you to configure ads in several locations
https://discuss.flarum.org/d/4785-flagrow-ads-bombarding-your-users-with-ads-everywhere-if-you-want
MIT License
18 stars 9 forks source link

add ukrainian locale file #7

Closed dshovchko closed 7 years ago

dshovchko commented 7 years ago

I have added a parameter for specifying the position from which to start to show the ads

admin

forum

dshovchko commented 7 years ago

The changes to add the "start from" logic was added in the dist folder, this is a compiled version of javascript in the src folder. If you want to implement this, you'd have to modify the javascript in the src folder and the re-compile using Gulp

I understand. I will do it!

Your new setting variable will never be distributed to the forum frontend because it's not registered in the Listeners\LoadSettingsFromDatabase

It has been done.

Could you first please PR the Ukrainian locale and then submit a PR for the "start from post" logic?

How do I do that? Revert the last commit?

luceos commented 7 years ago

Yes that's problematic. Under normal circumstances you create a branch for each feature and then PR those against the upstream (source). If you can fulfil the requirements I set out I'll gladly accept the combined PR though.

dshovchko commented 7 years ago

I will do everything in the right way