search

flagrow / flarum-api-client

The API client for working with your Flarum forum.
MIT License
31 stars 8 forks source link

Authorised example in README is wrong #11

Open pryley opened 6 years ago

pryley commented 6 years ago

It should be like this (notice the "Token " string before the token).

$api = Flarum('http://example.com', ['token' => 'Token <insert-master-token>; userId=1']);
clarkwinkelmann commented 6 years ago

Hi, thanks for the report !

The README is indeed incorrect for all versions released, but it isn't worth fixing anymore given the future release (dev-master right now) automatically adds the token prefix:

https://github.com/flagrow/flarum-api-client/blob/98bb9ba3b90f1ccbb1649c0ef1beaf9bbff954ae/src/Flarum.php#L107

Not sure when we'll work on this package again though... Let's keep this issue open in the meantime in case somebody wonders the same thing.

pryley commented 6 years ago

Have you abandoned the package?

clarkwinkelmann commented 6 years ago

@pryley we will publish any security update necessary, but as you can guess from the commit history it's been a while since we've worked on new features for the package.

If beta8 requires us to make changes to the package we will probably release an update.