search

flairNLP / fundus

A very simple news crawler with a funny name
MIT License
126 stars 63 forks source link

GH-124: Parse nested @graphs in LinkedData #130

Closed MaxDall closed 1 year ago

MaxDall commented 1 year ago

This addresses #124 by adding the functionality to access nested LDs to LinkedData.

closes #124

Weyaaron commented 1 year ago

The tests reveal a critical issue: This new parser crashes when the ld contains the same type twice. I have no clue how to resolve this unfortunately

MaxDall commented 1 year ago

The tests reveal a critical issue: This new parser crashes when the ld contains the same type twice. I have no clue how to resolve this unfortunately

The test cases worked before because we had overwritten the entry if we stumbled across the same key. As of now I'm no longer happy with this behavior and will rework LinkedData a bit.

alanakbik commented 1 year ago

A sidenote: very happy to see so much PR activity over the last days! And happy to see that the unit tests and the process of adding new parsers is helping make the interfaces/instructions more robust!

Weyaaron commented 1 year ago

This seems solid to me, I will implement parsers with it asap.