search

flairNLP / fundus

A very simple news crawler with a funny name
MIT License
126 stars 63 forks source link

Fix `iNews` parser #333

Closed MaxDall closed 2 months ago

MaxDall commented 4 months ago

This loosens the paragraph selector used by iNews.

Update: Example article

dobbersc commented 4 months ago

What concrete example does require this change? Maybe it would be nice to introduce it as a test case.

MaxDall commented 4 months ago

What concrete example does require this change? Maybe it would be nice to introduce it as a test case.

I added an example to the description.

Good idea. Fundus currently doesn't test the article body so that would be a bigger thing to implement.

Update: I opened a new PR #338 to deal with that.

dobbersc commented 4 months ago

Update: I opened a new PR https://github.com/flairNLP/fundus/pull/338 to deal with that.

Then, should this PR be merged after #338 including the test case?

MaxDall commented 3 months ago

I would like to merge this before #338 which seems to take quite a while.