flakes / mirc_fish_10

"FiSH 10" - a blowfish encryption script for mIRC 7, compatible to previous FiSH scripts and other clients! Come visit us in #fish10 on EFNet!
https://syndicode.org/fish_10/
86 stars 16 forks source link

mIRC 7.53 - outgoing chat is displayed twice #55

Closed owah closed 4 years ago

owah commented 5 years ago

I updated to mIRC 7.53 yesterday and since then every line I send, is displayed twice in my client. Once the way I am used to, and once with the arrow as well as asterisks. This happens in a query as well as in a regular channel.

[13:44:47] *** FiSH: Sent my DH1080 public key to participant, waiting for reply ...
[13:44:47] *** FiSH: Key for participant set to *censored*
[13:44:53] <me>· something something message 1
[13:44:53] -> *participant* something something message 1
[13:45:25] <me>· something something message 2
[13:45:25] -> *participant* something something message 2
[13:45:27] <me>· :-|
[13:45:27] -> *participant* :-|
[14:02:28] <participant> ~sarcastic response~
flakes commented 5 years ago

what happens if you change the crypt mark to suffix (append) instead of prefix (prepend)?

gh0stface1 commented 5 years ago

whatever the crypt mark is set to prefix or suffix, you get the message twice as shown before

BBen1979 commented 5 years ago

Update

When you turn off the "crypt-mark (outgoing) to OFF the issue is gone.


Samething here, Upgraded from a older version 7.xx to 7.55 and the issue started.

Setting crypt mark prefix,suffix,disabled didn't change anything.

It's annoying as hell. :)

I turned off fish_10.mrc and it work fine.

Thanks for all the work Flakes btw!

ShareScene commented 5 years ago

We need a proper working version of blowfish for mirc 7.55 because this version fix a critical secure issue present in all versions

flakes commented 5 years ago

Looks like it's a mrc script issue, we probably need some flag or something. Unfortunately, I have not been able to find the correct flag... therefore all I can do at this point is recommending to turn off outgoing crypt marks for now...

flakes commented 5 years ago

Responsible code is this: https://github.com/flakes/mirc_fish_10/blob/master/fish_10.mrc#L36

silv3rr commented 5 years ago

replace https://github.com/flakes/mirc_fish_10/blob/8b61aaf4dbea5ae5825f1e56dc03cca6bebbd716/fish_10.mrc#L74 with smth like:

    if ($target ischan) { .msg $target $1- }
    else { .privmsg $target $1- }
    halt
flakes commented 4 years ago

The fix has been incorporated into the new version. Thanks!