flakes / mirc_fish_10

"FiSH 10" - a blowfish encryption script for mIRC 7, compatible to previous FiSH scripts and other clients! Come visit us in #fish10 on EFNet!
https://syndicode.org/fish_10/
86 stars 16 forks source link

DH1080_comp output not SHA256 hashed #72

Closed maroonbells closed 12 months ago

maroonbells commented 3 years ago

Change from $dll(fish_10.dll,DH1080_comp,privkey pubkey) to $dll(fish_10.dll,DH1080_comp,privkey pubkey [1]) where the 3rd parm ="1" returns mime(computed) instead of mime(sha256(computed))

flakes commented 3 years ago

Why would this be required?

maroonbells commented 3 years ago

It's not required but it's an improvement. It shortens the DH public and private mime strings by 1 byte by removing the meaningless "A" from the tail end. I've never seen anything else append the A like this, and the DLL already handles the keys perfectly fine without the A.