flakestry / flakestry.dev

A public central registry of Nix flakes.
https://flakestry.dev
Apache License 2.0
93 stars 8 forks source link

devenv: inject <noscript-tag> after build #42

Open vhsconnect opened 6 months ago

vhsconnect commented 6 months ago

Informs users that they need to whitelist the site to view the SPA. Couldn't find a way to do within elm.

closes #27

vhsconnect commented 5 months ago

This works for me personally. I just want a reminder to whitelist the site instead of landing on a black screen. Also lets wait and see if @domenkozar will accept the pr.

Keep in mind that this is a tag that is injected into markup after the build. Adding link tags in that context is not so clean. Not sure how a link to an 'about' page would help? It's all spa - the user wouldn't be able to see anything there until he whitelists the site

domenkozar commented 5 months ago

The correct way to do this is to define a global layout in Elm and put it there.

I'll hack on this during thaigersprint.org in two weeks.

vhsconnect commented 5 months ago

Ok then, I'll keep this open but feel free to close it once you have the global layout in. Have fun - looks amazing!