search

flamapy / flamapy_fw

This repository hosts the main components of flamapy
4 stars 5 forks source link

Adding AST for CTC #10

Closed drorganvidez closed 3 years ago

drorganvidez commented 3 years ago

Preliminary version

Virako commented 3 years ago

hello, try to apply the tools to code quality and styles https://github.com/diverso-lab/core#review-code-quality-and-styles-error

Virako commented 3 years ago

Try to use the type hints, please: https://docs.python.org/3/library/typing.html

Virako commented 3 years ago

tests should be check with assertions, similar to https://github.com/diverso-lab/core/blob/master/tests/core/test_discover.py. In this way, when we execute 'python -m pytest', tests should appear

jagalindo commented 3 years ago

@drorganvidez Has this been checked out?

drorganvidez commented 3 years ago

Tomorrow morning you will have it, my apologies!

jagalindo commented 3 years ago

What's the current status of this? Should we close this request?