feat: Adding AST - Githubissues

flamapy / flamapy_fw

This repository hosts the main components of flamapy

4 stars 5 forks source link

Closed drorganvidez closed 3 years ago

jagalindo commented 3 years ago

Checked. While this merges fine. This is not yet ready. Shouldn't the nodes include a Feature type

jagalindo commented 3 years ago

So this has been integrated @drorganvidez. However, there is room for improvements in the AST class.
Mark these TODOS:

Justify that usage of static methods, dunno if this is correct.
The terminal nodes should be of type feature if possible
There are mixed language comments in this code. The official language of this tool is English
Heper methods to traverse the tree when creating constraints will be welcome