search

flamapy / flamapy_fw

This repository hosts the main components of flamapy
4 stars 5 forks source link

Fix operation from file parameters and usage from http api #54

Closed pabpazjim closed 2 years ago

pabpazjim commented 2 years ago

Fix #52 error of use_operation_from_file method not allowing extra parameters on operations requiring them.

Fix #49 error of use_operation_from_file method not being usable from HTTP API.

jagalindo commented 2 years ago

@pabpazjim Please give me a head up when done.

pabpazjim commented 2 years ago

@jagalindo this works from now. You can give configs as a string when running operations and they are automatically parsed to Configuration objects and set to the operations.

However, there is a couple of issues. First, str to Configuration parsing methods have to be built on plugin's transformation classes. Second, strings are the only way to give configs as an input, which is great for the API, but it would be good if Configuration objects could also be given as an input for programmatic usage.

I will give it a thought tomorrow and try to come up with a better solution design-wise.