search

flamapy / flamapy_fw

This repository hosts the main components of flamapy
4 stars 5 forks source link

Error when bdd_metamodel is installed as a plugin #78

Closed pabpazjim closed 2 years ago

pabpazjim commented 2 years ago

I am finding some errors when installing bdd_metamodel in my develop environment, in addition to the rest of plugins.

Everything works fine as long as just fm and pysat are installed. However, by adding bdd_metamodel as a plugin I have found the following errors so far when running operations from DiscoverMetamodels:

  1. Some operations return a NotImplementedError exception. Tested with Valid operation: image
  2. Some operations return an output with no errors, but it is returned as famapy non-legible objects, which did not happen before bdd_metamodel installation. This example comes from Products operation, which used to return a list of lists of the legible feature names: image
  3. bdd_metamodel operations themselves do not work, returning OperationNotFound exception. Output when running Sampling operation: image

@miguelijordan please try checking this to see if you find the same errors. I am installing bdd like the other plugins, so it could be either a core or bdd error what is causing this.

jagalindo commented 2 years ago

Reviewed and accepted. This clearly resolves the issue. @Virako , please PR and and I'll merge into develop