flamapy / flamapy_fw

This repository hosts the main components of flamapy
4 stars 5 forks source link

Decouple configuration from the core. It does require to analyze how this is working #87

Closed jagalindo closed 2 years ago

jagalindo commented 2 years ago

Currently, when a configuration is required for the operation is relying on a default csv reader. This is not ideal and should be improved before generating the 1.0.0 release. This is how is now def configure_operation(cls, operation: Type[Operation], src: VariabilityModel) -> Operation:

    configuration_builder = OperationConfigurator(operation, src)

    if configuration_builder.is_operation_configurable():
        result = configuration_builder.configure_from_csv()
    else:
        result = operation()

    return result

But the configuration concept is a core concept that should be properly implemented

jagalindo commented 2 years ago

I'd ask for help if needed to @Virako and @miguelijordan