flamapy / fm_metamodel

This repo host the feature model concrete classes
3 stars 5 forks source link

afm, uvl and xml transformation/writer testing #32

Closed pabpazjim closed 3 years ago

pabpazjim commented 3 years ago

Added 48 models to test fm_metamodels transformations, while also including:

Virako commented 3 years ago

There are some errors about afmparser, I unsdertand that we want to use https://github.com/diverso-lab/afm-parser but is not added as dependency.

Virako commented 3 years ago

Fix mypy errors. The problem is that self.model in https://github.com/diverso-lab/fm_metamodel/pull/32/files#diff-4e18c2f8bc0dd6da8ec67de3e120c43d3e4f304e553560a921d3d8e662719bbdR30 can be None, then the line 66 https://github.com/diverso-lab/fm_metamodel/pull/32/files#diff-4e18c2f8bc0dd6da8ec67de3e120c43d3e4f304e553560a921d3d8e662719bbdR66 when we call to self.model.get_feature_by_name could fail. The options are:

Virako commented 3 years ago

The tests are great and work!! :+1: