search

flamapy / fm_metamodel

This repo host the feature model concrete classes
3 stars 5 forks source link

Split functionality of feature model #41

Closed jmhorcas closed 2 years ago

jmhorcas commented 2 years ago

I would suggest to split (if possible) the current functionality of the feature model module into the actual one and another called extended_feature_model or attributed_feature_model with the new functionality related to attributes (Range, Domain, and Attribute classes).

The current module is too large and makes difficult to inspect the main base code for Feature, Relation, Constraint, and Feature Model.

jagalindo commented 2 years ago

That's something to think about. I'm ok as far as it doesn't affect the import part of the whole project. For example, is really needed to specify the path of each module or we can just rely on class names.

Any thoughts on using init.py for that @Virako?

jmhorcas commented 2 years ago

I'd bet for use the init.py for that, I think the benefits are majors than the inconveniences (unkown). Currently, fm_metamodel and bdd_metamodel use it, pysat_metamodel still does not.

jagalindo commented 2 years ago

Already solved in latest commits