flame-engine / flame

A Flutter based game engine.

https://flame-engine.org

MIT License

9.19k stars 899 forks source link

fix: Invoke `setToStart` on child effect controller of wrapping effect controllers #3168

Closed ufrshubham closed 4 months ago

ufrshubham commented 4 months ago

Description

DelayedEffectController was not calling setToStart on its child, causing it to not behave as expected when used with InfiniteEffectController. This was reported by a discord member in this message.

This PR introduces a HasSingleChildEffectController mixin which can be added to any effect controller that wraps a single child effect controller. This mixin makes sure that the setToStart, setToEnd and onMount methods always get invoked on the child controllers.

Checklist

[x] I have followed the Contributor Guide when preparing my PR.
[x] I have updated/added tests for ALL new/updated/fixed functionality.
[x] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[x] I have updated/added relevant examples in examples or docs.

Breaking Change?

[ ] Yes, this PR is a breaking change.
[x] No, this PR is not a breaking change.

Related Issues

NA