flame-engine / flame

A Flutter based game engine.
https://flame-engine.org
MIT License
8.98k stars 879 forks source link

refactor!: Make query() result an Iterable #3209

Closed filiph closed 6 days ago

filiph commented 1 week ago

Description

Avoid hard-to-detect bugs by disallowing people to touch the list that they get from query().

Checklist

Breaking Change?

Related Issues

filiph commented 1 week ago

As discussed, this PR includes a dart doc that might help developers when using query(). This change assumes the List --> Iterable change in OrderedSet.

spydon commented 6 days ago

ordered_set 6.0.0 is now released so this PR can be updated to depend on that :)

filiph commented 6 days ago

Done.