Open benni-tec opened 9 months ago
Would this help here? https://flutter.dev/go/move-flutter-agnostic-types
If yes, help me understand how. If not, what's missing?
Would this help here? https://flutter.dev/go/move-flutter-agnostic-types
If yes, help me understand how. If not, what's missing?
Yes! That would be exactly what we need here, it migrates all the types that we need out of flutter.
Thanks!
Description
This PR makes this package compatible with the Dart SDK. In order to achieve this I changed 3 things:
dart:ui
's Color with a simple ColorData classRect
fromflame
withRectangle
fromdart:math
flutter_test
withtest
packageThe
ColorData
class is used excatly once for which I prepared a flame_tiled PR (however I need to wait until this is merged right) including conversion extensions.No
Rectangle
attribute is ever read inflame_tiled
, evensoflame
already contains conversion extensions!Checklist
fix:
,feat:
,docs:
etc).melos run analyze
fails due toXmlData.value
however I think this requires another issue/PRdocs
and added dartdoc comments with///
.examples
. --> I don't think there are any exmaples necessary for thisBreaking Change
I think this should result in a minor version bump to 0.11.0 to indicate these breaking changes!
In order to achieve dart comaptibilty only two things changed:
flame_tiled
contains a conversion extensiondart:math
's Rectangle --> Useflame
'stoRect()
method to convertRelated Issues
69