Enable services in route definitions

[TomasVotruba]

Solves situation with filterIn/Out.

Big pron is that syntax is the same as in default RouterFactory.

I'm using this and it work properly.

---

Next step (not now) and more clear would be adding tag to the service (viz @matej21).

$router = $builder->getDefinition('router');
foreach(array_keys($builder->findByTag(...)) as $name) {
    $router->addSetup('offsetSet(?, ?)', array(NULL, '@' . $name));
}

What do you think?

[jsifalda]

Did you try whether the demo app is working with your patch? I am getting error Unable to create service 'routerServiceFactory.d6c5a2692a2df4bdf156a42fc8251c13', value returned by factory is not Nette\Application\IRouter type.. Can you check it please? Or what should I do to correct working?

[TomasVotruba]

I'll check it, didn't have much time today.

[jsifalda]

Great, thank you!

[TomasVotruba]

Try it now.

If it still doesn't work, could you share composer.json for demo?

[TomasVotruba]

I just added commit that enabled loading routers by tag.

I consider it best practice, since you can use same format as in sandbox router.

To add service to routes, just add a tag (config.neon):

services:
    -
        class: App\CoreModule\Routing\RouterFactory
        tags: [flame.modules.router]

[jsifalda]

Well, now it's working after I put the semicolon into file AppExtension.php on line 26 in demo ;)

A definitely want merge improvements which you committed (I really love tagging services!). However, I want to keep routes mock in modules as well. Can you prepare another pull request which would solve this issue please? Thank you again!

[TomasVotruba]

Thanks! Tagging is the way for service approach :).

I am not really sure what and where exactly you want to keep. If it is not much work for you, maybe we could skip explanation and you could merge this and apply fixes you need. Would that be ok for you?

[jsifalda]

Ok, I will do it;)

[TomasVotruba]

@jsifalda Ping, it starts to being rotten. Do you need help with anything to merge this?

I would like to use in multiple project and I don't want to extend composer by my repo vcs :)

[jsifalda]

@TomasVotruba I am sorry for my delay.

The problem is I am not sure if is it working... Can you add example of usage features in this pull into demo?

The routes definition in AppExtension contain syntax error (as mentioned before). The problem is the routes definition in the Extension is not working at all.

What I can skip, but I don't like it, is using of [] intend of array() ;)

And last thing please persist implementation of NetteRouteMocks. I am not sure how is it working and I don't have enough time to became more familiar with it. :)

Thanks a lot!

[TomasVotruba]

I understand your concerns, thanks for heads up!

• [x] I shall attach tests then. I think it's more reliable then static demo code, as you can see.
• [x] array() is fine
• [x] persist NetteRouteMocks

I'll ping when I'm ready with this.

[jsifalda]

Yes, of course, tests would be great! But example in demo is mostly for people who want to see how to use it :) Thank you again!

[TomasVotruba]

How to use it is already here, isn't it? http://flame-org.github.io/Modules/

[jsifalda]

That is true! Well, I will add example to http://flame-org.github.io/Modules/ :)

[TomasVotruba]

Test's were added, also for PHP 5.3, 5.5 and 5.6 I fixed macro test and tracy tests.

All works: https://travis-ci.org/TomasVotruba/Modules/builds/34099057

Two more suggestion before merge:

1) Move tests in demo test and remove demo folder. It really has no use when all is explained on page and in tests.

2) Also, do you want to support Nette cs? There is a lot of mess in the code (files are very different) and it would make it more readable for other programmers.

[TomasVotruba]

Thank you!

[jsifalda]

Thanks a lot for great job!;)

[TomasVotruba]

I'm glad you are open to changes. Now this package has everything I need :)

[jsifalda]

be sure!;) Great to hear you will be using the package!