flame / blis

BLAS-like Library Instantiation Software Framework
Other
2.18k stars 362 forks source link

arm64 cpu identification is not portable to BSDs #795

Open j-bm opened 4 months ago

j-bm commented 4 months ago

The bli_cpuid.c code for ARM64 is fairly complex, relies on linux-isms and therefore is not portable to *BSD systems.

There is some #ifdef for Apple that seems redundant, though I must say I am not able to test this.

devinamatthews commented 4 months ago

Yes this is a known problem. Do you happen to know what the equivalent mechanism to HWCAP is on BSD?

j-bm commented 4 months ago

I'm slowly becoming more knowledgeable about aarch64 machines...

It seems Linux user-mode runs at EL1 allowing access to CPU feature registers like MIDR or ID_AA64PFR0_EL1 to succeed.

OpenBSD (at least) runs at EL0 therefore these instructions fail with SIGILL (illegal instruction).

I see two paths forward: grep the dmesg output for indicators; OpenBSD for now does not publish the full CPU feature set in the dmesg output for aarch64 (it does so for most other architectures.)

Or run test code, trap SIGILL and revert to "generic" if needed.

Both look about as hacky as can be imagined.

(I don't know what Apple machines do.) I'm testing on Raspberry Pi 4B.