flame / blis

BLAS-like Library Instantiation Software Framework
Other
2.18k stars 362 forks source link

errors with scalapack due to [cz]symv and [cz]syr interfaces #812

Closed ajaypanyala closed 2 weeks ago

ajaypanyala commented 2 weeks ago

Using BLIS to configure Reference LAPACK and ScaLAPACK, results in link errors (duplicate definitions) due to the [cz]symv and [cz]syr interfaces introduced in Commit 37ca4fd. ScaLAPACK defines them here

devinamatthews commented 2 weeks ago

I guess we need a configure flag to turn these off.

fgvanzee commented 2 weeks ago

Regardless of what we do, maybe LAPACK/ScaLAPACK need a configure flag to turn them off on their side.

ajaypanyala commented 2 weeks ago

ScaLAPACK works fine with BLIS before Commit 37ca4fd. There doesn't seem like a way to turn those interfaces off in ScaLAPACK.

devinamatthews commented 2 weeks ago

My only concern is whether this should be an option specific to those operations or if it should be a generic "ScaLAPACK compat" option in case something else comes up.

devinamatthews commented 2 weeks ago

@ajaypanyala is [cz]syr2 affected?

devinamatthews commented 2 weeks ago

Looks like it is.

ajaypanyala commented 2 weeks ago

Atleast on my end, I do not see any issues with [cz]syr2

devinamatthews commented 2 weeks ago

It's because I didn't enable them in BLIS when I did [cz]syr and [cz]symv which was an oversight on my part. I've included all 3 in the fix.

devinamatthews commented 2 weeks ago

@ajaypanyala please try the branch scalapack-compat and configure with the option --enable-scalapack-compat.

ajaypanyala commented 2 weeks ago

Using scalapack-compat branch with --enable-scalapack-compat worked. thanks!