Fix a bug in the piledriver microkernels.

flame / blis

BLAS-like Library Instantiation Software Framework

Other

2.18k stars 362 forks source link

Closed devinamatthews closed 1 week ago

devinamatthews commented 1 week ago

Details:

At some point, the piledriver (and bulldozer and excavator) microkernel tests via SDE had been removed from Travis CI testing. This PR re-enables them.
A bug in the piledriver complex gemm microkernels has also been fixed. The beta*C product was not being correctly added to the A*B product before writing back out to memory.
Fixes #811.

devinamatthews commented 1 week ago

Oops I need to rebase from master. I used r1.x as the base.

devinamatthews commented 1 week ago

This first commit is intended to fail in order to check that the bug is now being detected by Travis. Then I'll commit the fix.

fgvanzee commented 1 week ago

Looks good. Thanks for looking into it, @devinamatthews. Is it ready to merge?

(I've applied commit log entry-style formatting to the description of this PR, so you're welcome to merge when ready.)