Closed zbentley closed 7 months ago
@djc you want me to bump shlex to resolve that audit advisory build failure?
I did this as the new version seems harmless, as this crate doesn't seem to be depending on any of shlex
's functionality that was deprecated or changed while fixing the security vuln.
Addresses/mitigates #229
Two changes in this PR:
cargo flamegraph
on MacOS without the--root
flag.--root
flag oversudo cargo
.Additional things that I could do if needed:
cargo
standaloneflamegraph
binary. I didn't do that because dtrace will indicate an error anyway without permissions, andsudo flamegraph
isn't as much of a problem assudo cargo
.cargo flamegraph
binary, telling people not to run cargo as root. That seems overly perscriptive as there are probably some folks who intentionally do this.