search

flamelink / gatsby-source-flamelink

Gatsby source plugin for Flamelink
MIT License
8 stars 9 forks source link

Caching not working 100% #21

Open jperasmus opened 4 years ago

jperasmus commented 4 years ago

Depending on the content, sometimes the build throws an error because of a missing node ID.

d4rekanguok commented 4 years ago

I think it might be due to a flaw in the way I cache images in #7 — In image.js, there's a case that the if/else block doesn't handle. I found the problem and fixed it in another plugin of mine:

https://github.com/d4rekanguok/gatsby-remark-images-anywhere/commit/e680880533ea7ab6c21428c80746ee9c0d6ec978

I can take a look & send a PR if necessary when I can!

jperasmus commented 4 years ago

Ah, great, thanks for the info and the link to where you fixed it. If you find time to look at this, it would be awesome - if you do, simply assign the task to yourself so that I know you're looking into it. Otherwise, I'll also use the reference code you linked to, to see if I can fix it when I get some time.