search

flamendless / Slab

An immediate mode GUI for the Love2D framework.
MIT License
294 stars 25 forks source link

Wrong "Channel Count" in DrawCommand stats #113

Open megagrump opened 2 years ago

megagrump commented 2 years ago

Looking at issue #112, the "Channel Count" statistics is not accurate. It shows a value of "0" for every layer even though there are obviously more than 0 channels in some layers (otherwise no UI would be visible on screen).

The GetLayerDebugInfo function in Internal/Core/DrawCommands.lua is faulty. It uses the length of the Layer table for statistics, which is always 0 - it's a hash table that has no length.

As I'm trying to optimize the DrawCommands module for performance, I wonder if Channel Count is an important metric at all? I don't even understand what "Channel" even means in this context.

flamendless commented 2 years ago

Hmm right 🤔 i dont even know what channel is for in this context. I think it's just for demoing tree nodes but then again if i remember correctly there are other demos for nested tree nodes.

I'll take a closer look later and see if i can figure out its purpose. If not found, I'll remove it.

megagrump commented 2 years ago

Please leave it alone for the time being, until I'm done working on the DrawCommands module. It may fall all into place if I understand it better, and it may just need a better name.

flamendless commented 2 years ago

@megagrump i got an email notif about the styling issue but i dont see it anywhere. Did you delete it?

flamendless commented 2 years ago

Still cant. I get "no commit found for the ref 111"

flamendless commented 2 years ago

@megagrump yeah i click it and it doesn't redirect anywhere

I also dont see it in your forked repo 🤔