search

flameshot-org / flameshot-org.github.io

Flameshot official websites & documents
https://flameshot.org
24 stars 35 forks source link

style(header): remove toggle theme button outline on focus #102

Closed Hossein13M closed 1 year ago

Hossein13M commented 1 year ago

The toggle theme button on the header of the page has an outline on the user's focus. I have removed the btn-link class and handled the padding using tailwindCSS hence the outline has been removed.

mmahmoudian commented 1 year ago

Thanks for the PR. I don't quite understand what is this improving. Can you explain a bit more? Perhaps adding some screenshots can help me understand

Hossein13M commented 1 year ago

https://user-images.githubusercontent.com/45146636/205248998-0910c108-fda5-4d48-9f61-c69da71c9444.mp4

As you can see in the uploaded video, once the user clicks on the toggle-theme. button, there is an outline on the button that I have removed it. @mmahmoudian

mmahmoudian commented 1 year ago

Thank for the clear explanation. I though it was that, but I thought I should ask to make sure and to learn something in the process :D

Now it is merged. But we have had an issue with the Github Action to update the website, so you will not see the result of your PR effect until we manage to fix that Github Action

mmahmoudian commented 1 year ago

@hossein13m There is an adverse event caused by this fix.: the color of the icon to toggle dark->light, will loose bright color and is practically invisible:

Peek 2022-12-05 12-27.webm

I have fixed the Github Action deployment issue, so now you can see the effect on the website. Do you have any quick fix for that?

Hossein13M commented 1 year ago

I have opened a new PR on #105 which resolves the #104 @mmahmoudian