flameshot-org / flameshot-org.github.io

Flameshot official websites & documents
https://flameshot.org
25 stars 34 forks source link

A complete overhaul of files, but no major content change #22

Closed mmahmoudian closed 3 years ago

mmahmoudian commented 3 years ago

Basically added scoop and choco, fixed some typos and formatting errors. The rest are moving files into folders in a structure similar to the navigation menu of the website.

mmahmoudian commented 3 years ago

I'll do a Find&Replace for qmake -> cmake except for qt5-qmake. but do we still need qt5-qmake?

holazt commented 3 years ago

I'll do a Find&Replace for qmake -> cmake except for qt5-qmake. but do we still need qt5-qmake?

https://github.com/flameshot-org/flameshot/blob/master/.github/workflows/build_cmake.yml No need for it.

mmahmoudian commented 3 years ago

@ZetaoYang I think all are resolved now. Would you please check again.

mmahmoudian commented 3 years ago

@ZetaoYang please check the last line of docs/guide/installation/compilation.md as I also changed the cmake command there as well.

borgmanJeremy commented 3 years ago

Is this good to merge?

mmahmoudian commented 3 years ago

@borgmanJeremy I was hoping that @ZetaoYang and you can review and tell me if the data is valid to be merged.

mmahmoudian commented 3 years ago

@borgmanJeremy I think @ZetaoYang didn't have time to review. For the time being, I will merge this and we can later do point-fixes.