search

flameshot-org / flameshot-org.github.io

Flameshot official websites & documents
https://flameshot.org
24 stars 35 forks source link

Zola Merge #38

Closed borgmanJeremy closed 2 years ago

borgmanJeremy commented 2 years ago

Needed to re submit the PR after resolving conflicts

borgmanJeremy commented 2 years ago

@mmahmoudian @Correct-Syntax I created this PR after resolving the merge conflicts but the pipeline fails.

Before we merge this do I need to generate a secure token and store it in the vault?

Correct-Syntax commented 2 years ago

@borgmanJeremy I believe I had to setup Actions Secrets in order for it to work.

Mine is setup like:

Environment secrets TOKEN

Repository secrets GP_TOKEN

mmahmoudian commented 2 years ago

do I need to generate a secure token and store it in the vault?

I don't see why it would nee a secret token! I'll investigate as well

mmahmoudian commented 2 years ago

our current Action file for mkdocs does not use any token and it works just fine. According to the shalzz/zola-deploy-action which we will use for Zola:

TOKEN: Personal Access key with the appropriate scope. If the repository is public the public_repo scope suffices

I don't see why we would need to define a token, but considering the error we got in the GH Page check, we would need to define a secret in the environment.