search

flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
24.69k stars 1.58k forks source link

Flameshot doesn't always return focus using when XSetInputFocus to take focus (overlay ) #1694

Open mattbdc opened 3 years ago

mattbdc commented 3 years ago

➜ ~ flameshot --version Flameshot v0.8.3-2(Debian) Compiled with Qt 5.14.2

Describe the bug On certain window managers does not return focus to client. i3 describes this as mis-behaving flameshot and have fixed it with https://github.com/i3/i3/commit/a06e66982bc921d05b68b75f8e12323c284233d0 Bug is present in AwesomeWM and possibly other WMs that aren't accounting for this behavior. https://github.com/awesomeWM/awesome/issues/3379

To Reproduce AwesomeWM Open chromium or google-chrome Run flameshot to point where you are selecting an area to capture (i.e. overlay shows), press esc Return focus to chrome, right click on tabs doesn't work and keyboard shortcuts dont work in chrome

Expected behavior Focus returns to chromium, right click on tabs work and keyboard shortcuts work within chrome

System Information➜
~ lsb_release -a No LSB modules are available. Distributor ID: Pop Description: Pop!_OS 20.10 Release: 20.10 Codename: groovy

totoro-ghost commented 3 years ago

This happen for me too, on i3 wm. 

i3 --version
i3 version 4.18.2 (2020-07-26) © 2009 Michael Stapelberg and contributors
Flameshot v0.10.1
Compiled with Qt 5.12.8

I encountered this problem when I used this inactive-dim = 0.2 setting for my compositior picom, on taking some screenshot the window under focus is still dim.

mmahmoudian commented 3 years ago

For others reading this thread, it seems there is some solution in AwesomeWM end and it is confirmed by OP of this thread.

@mattbdc can this be closed? (although I myself am waiting for that PR in AwesomeWM)