search

flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
25.01k stars 1.6k forks source link

Build without network abilities #1760

Open jose1711 opened 3 years ago

jose1711 commented 3 years ago

For corporate environments I believe it would be useful to have ability to build flameshot without any network abilities so that there is less risk of leaking sensitive data.

avindra commented 3 years ago

I was surprised by the "update" notification. It would be nice to have a way to disable completely this feature (i.e., at build time, not via a configuration setting).

borgmanJeremy commented 3 years ago

You can disable the update checker.

But yes I agree , I'm already working on a cmake flag to patch out all network stuff.

mmahmoudian commented 3 years ago

@borgmanJeremy I believe the OP meant to disable any form of upload (duplicate of #1529)

@jose1711 can you clarify which one of these two are you looking for.

borgmanJeremy commented 3 years ago

oh I was thinking it was both.

Patch out uploading AND update checking (ie any network calls)

mmahmoudian commented 3 years ago

Then I think we can close #1529 as well when this is implemented.

kaihendry commented 3 years ago

How do you disable the update checker?

mmahmoudian commented 3 years ago

@kaihendry Simple: in the config file (~/.config/flameshot/flameshot.ini) set the update checking to checkForUpdates=false. But this is not the main topic of this issue as far as I can tell.

borgmanJeremy commented 3 years ago

Ive looked into this and just forgot to post an update.

It is very easy to simply build without network capabilities. It's NOT easy to fully remove the imgur button at compile time. We can compile out its function so it cannot do anything, but fully compiling out the button is very very difficult.

I propose we add the option to compile out the networking feature, but just leave the button as stub that does nothing (or pops up a box saying it was built with no network)

mmahmoudian commented 3 years ago

@borgmanJeremy I think showing a message after pressing the button is more transparent and clear (if it is not very difficult thing to do)

aliceinwire commented 2 years ago

Ive looked into this and just forgot to post an update.

It is very easy to simply build without network capabilities. It's NOT easy to fully remove the imgur button at compile time. We can compile out its function so it cannot do anything, but fully compiling out the button is very very difficult.

I propose we add the option to compile out the networking feature, but just leave the button as stub that does nothing (or pops up a box saying it was built with no network)

could you share your patch?

jwoodard80 commented 6 months ago

@borgmanJeremy ..... can you provide any update to this at all? Has this been done, if so, can documentation be provided as to how it is done? I'd love to be able to use this in my environment and it seems like things have changed so that the upload button might be disabled (unchecked) by default.

Thank you so much for any work or consideration in advance. :-)

borgmanJeremy commented 6 months ago

I'm no longer a maintainer due to time constraints. My personal fork removes all networking so you can take a patch from that: https://github.com/borgmanJeremy/flameshot

matykare commented 1 month ago

Hello, Can you provide me with the new installation source for flameshot has seen the patch made to disable the networking feature for windows ?

borgmanJeremy commented 1 month ago

If you go to my fork you can build a version will all networking removed from the source.