flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
24.66k stars 1.58k forks source link

AppImage prints "Run experimental self-contained bundle" #1963

Closed veracioux closed 2 years ago

veracioux commented 2 years ago

Flameshot version

Flameshot v0.10.1 (0e43d4b) (AppImage) Compiled with Qt 5.12.8

Describe the bug When I run ./Flameshot-0.10.1.x86_64.AppImagewith or without subcommands/options, the output contains "Run experimental self-contained bundle". This is a problem when you run Flameshot-0.10.1.x86_64.AppImage gui --raw. The output is corrupted by that first line and does not represent a valid image.

Expected behavior Print only the raw image data to stdout. Nothing else should be printed or at least printed to stderr.

System Information OS: Arch Linux Kernel: 5.13.13-arch1-1 WM: i3wm, X11

Maybe the following info could help solve the problem:

Under the directory where the AppImage filesystem is mounted (on my system it's /tmp/.mount_Flame*, where * is replaced by a random string), you can find an AppRun file. In this file there is an echo "Run experimental self-contained bundle" command.

mmahmoudian commented 2 years ago

It seems we have had this at least since v0.8.3 (#1002). Also Googling the error was very interesting as I found these:

https://www.mail-archive.com/debian-bugs-dist@lists.debian.org/msg1812107.html (from Thu, 22 Jul 2021)

But it seems it is not specific to Flameshot because @probonopd also got this while making an AppImage for LibreCAD: https://githubmemory.com/repo/probonopd/go-appimage/issues/148

@probonopd Any insights and help is highly appreciated.

borgmanJeremy commented 2 years ago

@mmahmoudian I dug into this and there are two ways we can fix it ourselves.

  1. Switch back to the original appimagetool, this will drop support for 14.04 (which IMO is reasonable).
  2. Patch the appimagetool in the CI to remove the echo statement: https://github.com/probonopd/go-appimage/blob/52cd7738cd29ce366106aa9010ccf797b0bde1f6/src/appimagetool/appdirtool.go#L109

Im leaning towards just patching that file and submitting an issue upstream to have an option to remove that statement.

mmahmoudian commented 2 years ago

this will drop support for 14.04

If you mean Ubuntu 14.04, then by all means as its end of life was April 30th 2019.

Im leaning towards just patching that file and submitting an issue upstream to have an option to remove that statement.

Fair point. My vote is almost always on customizability 😅

probonopd commented 2 years ago

Build 649 and later should have the message removed.

borgmanJeremy commented 2 years ago

@probonopd Thanks! just re-ran our pipeline and confirmed its resolved.

liziru commented 2 years ago

@probonopd谢谢!只需重新运行我们的管道并确认其已解决。

@probonopd Thanks! just re-ran our pipeline and confirmed its resolved.

I find this problem when running 0.10.1.AppImage, and found no any outputs when running 0.10.2.AppImage. And both two versions cannot start screenshoting.
Any advice to solve this problem? image image

mmahmoudian commented 2 years ago

@liziru perhaps you can start by telling us you system information

Also please note that unless you are a Wayland user, 0.10.2 or 0.10.1 shouldn't make a big difference for you.