search

flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
24.6k stars 1.58k forks source link

Implement the same CLI args in Windows build #2118

Open gabdevbr opened 2 years ago

gabdevbr commented 2 years ago

Flameshot Version

image

Installation Type

Using the ready-made package from Github Releases

Operating System type and version

Windows 10 Pro

Description

Implement the same arguments that works in Linux in Windows.

E.g, this command:

"C:\Program Files\Flameshot\bin\flameshot.exe" gui

Does not work in Windows 😭

Steps to reproduce

  1. Press WinKey + R
  2. Fill "C:\Program Files\Flameshot\bin\flameshot.exe" gui
  3. Press enter

Screenshots or screen recordings

No response

System Information

HOW?

image

hey-thanks commented 2 years ago

Has there been any progress on this? I am having the same issue (Windows 10 Pro, Flameshot version 11 - installed using the ready-made package on GitHub Releases). I'm willing to help out, if possible.

borgmanJeremy commented 2 years ago

Nope, feel free to take a crack at it.

jrozner commented 2 years ago

Reading through some of the other tickets there is some technicality that needs to be worked around. Can that get documented here? this is something straight forward I may have some time to go and do it.

mmahmoudian commented 2 years ago

@jrozner can you be more specific about the workaround that you want to have in documentations?

jrozner commented 2 years ago

https://github.com/flameshot-org/flameshot/issues/2335#issuecomment-1024275873 is the comment I'm referring to. Is there something specific about the command line parsing that doesn't work on windows?

borgmanJeremy commented 2 years ago

I dont recall the details of the issue anymore.

davidbrinton commented 1 year ago

Just adding my voice of support to this issue. If we're going to use Flameshot in our cross platform application we would have to have the CLI piece working for Windows as well as Mac. Sound like it might work in Mac already though.

mmahmoudian commented 1 year ago

@davidbrinton it works on any unix-line OS including Linux, MacOS, and BSDs.

We need to keep the threads right to the point. Please consider commenting in the thread if you have something to add to the discussion (e.g new approach, potential limitations, possible implementation strategies). To show your support of a feature, you can for instance you can like the original post. Thank you.

I'll hide your comment and this response of mine hidden in few hours.

goproslowyo commented 1 year ago

Hey @gabdevbr & @jrozner!

I've remapped my keys using PowerToys and it works beautifully:

image

CvH commented 1 year ago

While nobody working to fix this are there any workarounds to upload your screenshots to other sites ? Normally I would use the cli options at windows to trigger the upload to a 3rd party site, that isn't working at so are there any alternatives ?

mmahmoudian commented 1 year ago

@CvH

nobody working to fix this

You are welcome to work on it.

Normally I would use the cli options at windows to trigger the upload to a 3rd party site, that isn't working at so are there any alternatives ?

imho you are on the wrong operating system if you want to have freedom. But I don't understand why existing methods does not work for you. You can use rclone or curl if you want to do this via CLI. It depends on what platform is your target, but you should either work with their API or use one of these.

CvH commented 1 year ago

But I don't understand why existing methods does not work for you.

The script is not the problem, its just the mentioned flameshot cli that is not working. So any kind of variant of flameshot gui --path "${FILE}" is not working. Not entirely sure how curl or rclone would workaround the missing trigger for flameshot ? I want is basically make a screenshot and upload it to somewhere else or hand it over to some script at windows.

There is also a window where you could select some program to open, that is broken too and does nothing. image

mmahmoudian commented 1 year ago

@CvH

its just the mentioned flameshot cli that is not working.

it does not work because it is not implemented. Therefore, there is no alternative.

There is also a window where you could select some program to open, that is broken too and does nothing.

This is off-topic and you should open a separate bug report for it.

I have to mark both your comments and my reply as off-topic. they are not adding to the conversation nor they are helping the design or implementation process.

lahma0 commented 7 months ago

Is there anyone who could offer a little more insight/knowledge about what is causing issues with the CLI on Windows? Considering this issue has been around for 3+ years, it wouldn't surprise me if no one remembers any specifics, but it would be really helpful to have some additional insight into the issue if I decide to try fixing the issue myself. If not, no biggie.. I will just have to see what I can do without any help.

mmahmoudian commented 7 months ago

@lahma0

Is there anyone who could offer a little more insight/knowledge about what is causing issues with the CLI on Windows

I remember. Simply, it is not implemented. Please feel free to attempt implementing it and create a PR. :) any contribution is very welcome