search

flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
24.98k stars 1.6k forks source link

Please allow screenshot 90/180/270 degree rotation #2214

Open elad2109 opened 2 years ago

elad2109 commented 2 years ago

Feature Description

Discussed in https://github.com/flameshot-org/flameshot/discussions/2213

Originally posted by **elad2109** January 1, 2022 As gmail doesn't support rotation, it will save lots of work rotating this on flameshot.
veracioux commented 2 years ago

I'd personally prefer adding support in flameshot for user scripts/plugins that will implement this type of functionality.

elad2109 commented 2 years ago

I'd personally prefer adding support in flameshot for user scripts/plugins that will implement this type of functionality.

Why this specifically? Or in general the ability to add plug-ins?

But then, a user who is not tech savvy would be able to download the plug-ins?

veracioux commented 2 years ago

@elad2109 Because it would be easy to implement using scripts/plugins. And I think this doesn't have to be in the core of flameshot.

But then, a user who is not tech savvy would be able to download the plug-ins? Yes of course.

mmahmoudian commented 2 years ago

@elad2109 even without the plug-ins one can already do that if they are slightly tech savvy. For example in bash using ImageMagic on can do:

convert image.jpg -rotate -90 rotated_ccw.jpg

For more examples checkout:

https://stackoverflow.com/questions/14751011/how-to-rotate-an-image-without-changing-its-size

The whole point of a plug-in system is to make it easier for the non-tech savvy users to do what they want without bloating the Flameshot itself.

I agree with @veracioux that this easily pass the criteria of a plugin. We haven't yet decided and fully discussed what the plugin implementation should/can be or even what language(s), but I think there is a consensus understanding that plugins should be supported to keep Flameshot lightweight and yet feature-rich and extendible.

elad2109 commented 2 years ago

Thanks

@elad2109 even without the plug-ins one can already do that if they are slightly tech savvy. For example in bash using ImageMagic on can do:

Never claimed it cannot be done outside of flameshot. One can also paste it in editing app, rotate and save. It's all a matter of using less steps.

I agree with @veracioux that this easily pass the criteria of a plugin. We haven't yet decided and fully discussed what the plugin implementation should/can be or even what language(s), but I think there is a consensus understanding that plugins should be supported to keep Flameshot lightweight and yet feature-rich and extendible.

May I ask if all the current features are essentials (in order to keep flameshot as lightweight as possible)? Taking this one step further, may I suggest to analyze user hot-zones to check which features can be factored out to a plug-in and which ones are highly used and should be added to a release version?

mmahmoudian commented 2 years ago

@elad2109

May I ask if all the current features are essentials

So far we had the suggestions to add the following and they will end up in a plugin system:

There is most definitely some more things that I have missed, and way more feature request issues that I didn't include here. This list is just as an example and not a full compilation of issues and titles.

If the plugin system is implemented, Flameshot will be shipped with some default plugins installed (at least the imgur upload) and those will be the features that the majority of users use.

may I suggest to analyze user hot-zones to check which features can be factored out to a plug-in and which ones are highly used and should be added to a release version?

If you have a good way to do this, feel free to do so. But please discuss your approach with devs first. We can use our Mastodon and other places to attract more attention from users to participate.

gustavotrott commented 1 year ago

@elad2109

May I ask if all the current features are essentials

So far we had the suggestions to add the following and they will end up in a plugin system:

There is most definitely some more things that I have missed, and way more feature request issues that I didn't include here. This list is just as an example and not a full compilation of issues and titles.

If the plugin system is implemented, Flameshot will be shipped with some default plugins installed (at least the imgur upload) and those will be the features that the majority of users use.

may I suggest to analyze user hot-zones to check which features can be factored out to a plug-in and which ones are highly used and should be added to a release version?

If you have a good way to do this, feel free to do so. But please discuss your approach with devs first. We can use our Mastodon and other places to attract more attention from users to participate.

Hey, any update on this? Looking forward to be able to use the plugin system!

mmahmoudian commented 1 year ago

@gustavotrott Please follow #2529 for that